> On Jun 22, 2023, at 12:40 PM, stsp <stsp2@xxxxxxxxx> wrote: > > 22.06.2023 16:48, Jeff Layton пишет: >> I'm not opposed to adding a selftest here, but most filesystem testing >> is done via xfstests: >> >> https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/ >> >> It would be better to add this test to the existing generic/478 test >> that tests OFD locks. Can you patch that to add a test for the new >> functionality? I agree with Jeff, this test needs to go in xfstests. > I don't actually think its possible. > It seems like their script creates 2 > t_ofd_locks processes, one for creating > the lock, one for testing it. > This is not our case. > To make it work our way, we'd probably > need to hack that test directly into > t_ofd_locks.c, so that it can set and test > from the same fd. Or you could add a new test program. > And I don't know how > to even run these tests. :) > So I am really inclined to limit myself > with a kernel selftest. IMO that's not a reason not to do this properly. You should work with Jeff and the maintainer of xfstests to make it happen. -- Chuck Lever
