On Sun, Jun 11, 2023 at 09:07:22PM +0100, Matthew Wilcox wrote: > On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote: > > Bagas Sanjaya <bagasdotme@xxxxxxxxx> writes: > > > > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote: > > >> From: Mao Zhu <zhumao001@xxxxxxxxxx> > > >> > > >> Delete duplicated word in comment. > > > > > > On what function? > > > > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our > > contributors into the ground? It appears I do. So: > > > > Bagas, *stop* this. It's a typo patch removing an extraneous word. The > > changelog is fine. We absolutely do not need you playing changelog cop > > and harassing contributors over this kind of thing. > > Amen. > Amen too. Hope I can learn from this. > > >> Signed-off-by: Mao Zhu <zhumao001@xxxxxxxxxx> > > > > > > You're carrying someone else's patch, so besides SoB from original > > > author, you need to also have your own SoB. > > > > This, instead, is a valid problem that needs to be fixed. > > I mean ... yes, technically, it does. But it's a change that deletes > a word in a comment. Honestly, I'd take the patch without any kind of > sign-off. It doesn't create any copyright claim, which is the purpose > of the DCO. What? Relaxed SoB requirement for trivial patches like this? I thought that SoB rules also apply to these patches. Thanks. -- An old man doll... just what I always wanted! - Clara
Attachment:
signature.asc
Description: PGP signature
