Re: [PATCH] fs: Fix comment typo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> From: Mao Zhu <zhumao001@xxxxxxxxxx>
> 
> Delete duplicated word in comment.

On what function?

> 
> Signed-off-by: Mao Zhu <zhumao001@xxxxxxxxxx>

You're carrying someone else's patch, so besides SoB from original
author, you need to also have your own SoB.

> ---
>  include/linux/fs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index df6c1817906f..aa870b77cc2b 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2675,7 +2675,7 @@ extern void evict_inodes(struct super_block *sb);
>  void dump_mapping(const struct address_space *);
>  
>  /*
> - * Userspace may rely on the the inode number being non-zero. For example, glibc
> + * Userspace may rely on the inode number being non-zero. For example, glibc
>   * simply ignores files with zero i_ino in unlink() and other places.
>   *
>   * As an additional complication, if userspace was compiled with

I don't see the function name in above diff (dump_mapping() isn't the
function I mean). Regardless, the fix LGTM.

@cdjrlc.com developers: I'm really, really fed up with you ignoring
review comments. It seems like you have issues on your mail setup. Fix
your mailer! Until then, I just say NAK.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux