On Tue, Jun 06, 2023 at 11:56:25AM +0200, Jan Kara wrote: > On Tue 06-06-23 11:32:53, Dan Carpenter wrote: > > Hello Jan Kara, > > > > This is a semi-automatic email about new static checker warnings. > > > > The patch afb4adc7c3ef: "fs: Restrict lock_two_nondirectories() to > > non-directory inodes" from Jun 1, 2023, leads to the following Smatch > > complaint: > > > > fs/inode.c:1174 unlock_two_nondirectories() > > warn: variable dereferenced before check 'inode1' (see line 1172) > > > > fs/inode.c:1176 unlock_two_nondirectories() > > warn: variable dereferenced before check 'inode2' (see line 1173) > > Indeed, thanks for spotting this! Luckily there are currently no in-tree > users passing NULL. Attached patch fixes this. Christian, can you please Thanks for the fixup! > add this to your branch or squash it into the fixed commit? Thanks! Of course. I've squashed the fix into the original patch. --- Applied to the vfs.rename.locking branch of the vfs/vfs.git tree. Patches in the vfs.rename.locking branch should appear in linux-next soon.
