[bug report] fs: Restrict lock_two_nondirectories() to non-directory inodes

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

Hello Jan Kara,

This is a semi-automatic email about new static checker warnings.

The patch afb4adc7c3ef: "fs: Restrict lock_two_nondirectories() to
non-directory inodes" from Jun 1, 2023, leads to the following Smatch
complaint:

    fs/inode.c:1174 unlock_two_nondirectories()
    warn: variable dereferenced before check 'inode1' (see line 1172)

    fs/inode.c:1176 unlock_two_nondirectories()
    warn: variable dereferenced before check 'inode2' (see line 1173)

fs/inode.c
  1171	{
  1172		WARN_ON_ONCE(S_ISDIR(inode1->i_mode));
                                     ^^^^^^^^^^^^^^
  1173		WARN_ON_ONCE(S_ISDIR(inode2->i_mode));
  1174		if (inode1)
                    ^^^^^^
  1175			inode_unlock(inode1);
  1176		if (inode2 && inode2 != inode1)
                    ^^^^^
regards,
dan carpenter