On Thu, Jun 01, 2023 at 05:27:40PM +0200, Christoph Hellwig wrote: > On Thu, Jun 01, 2023 at 08:25:36AM -0700, Darrick J. Wong wrote: > > > +_require_scsi_debug > > > + > > > +physical=`blockdev --getpbsz $SCRATCH_DEV` > > > +logical=`blockdev --getss $SCRATCH_DEV` > > > > These two tests need to _notrun if SCRATCH_DEV is not a blockdev or if > > SCRATCH_MNT is not a directory. Normally _require_scratch_nocheck takes > > care of that. > > > > Other than that they look ok. > > Can SCRATCH_MNT be not a directory? Good question. AFAICT the only checks on it are in _require_scratch_nocheck itself... > But yeah, these tests should simply grow a > > _require_block_device $SCRATCH_DEV ...but you could set up the scsi_debug device and mount it on $TEST_DIR/foo which would avoid the issue of checking SCRATCH_* entirely. (Please remember to _require_test if you do though.) --D
