On Thu, Jun 01, 2023 at 08:25:36AM -0700, Darrick J. Wong wrote: > > +_require_scsi_debug > > + > > +physical=`blockdev --getpbsz $SCRATCH_DEV` > > +logical=`blockdev --getss $SCRATCH_DEV` > > These two tests need to _notrun if SCRATCH_DEV is not a blockdev or if > SCRATCH_MNT is not a directory. Normally _require_scratch_nocheck takes > care of that. > > Other than that they look ok. Can SCRATCH_MNT be not a directory? But yeah, these tests should simply grow a _require_block_device $SCRATCH_DEV
