Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kent Overstreet <kent.overstreet@xxxxxxxxx>
Subject: Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 19 May 2023 21:17:43 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>
In-reply-to: <ZGhI/V573cMDhII5@moria.home.lan>

On Sat, May 20, 2023 at 12:13:49AM -0400, Kent Overstreet wrote:
> I suppose this way setting it can be done in bio_iov_iter_get_pages() -
> ok yeah, that makes sense.
> 
> But it seems like it should be set in bio_iov_iter_get_pages() though,
> and I'm not seeing that?

It is set in bio_iov_iter_get_pages in this patch.  The later gets
replaced with the pinned flag when we bio_iov_iter_get_pages is
changed to pin pages instead.

Follow-Ups:
- Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic
  - From: Kent Overstreet

References:
- [PATCH v20 00/32] splice, block: Use page pinning and kill ITER_PIPE
  - From: David Howells
- [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic
  - From: David Howells
- Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic
  - From: Kent Overstreet
- Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic
  - From: Christoph Hellwig
- Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic
  - From: Kent Overstreet

Prev by Date: Re: [PATCH v21 30/30] iov_iter: Kill ITER_PIPE
Next by Date: Re: [PATCH v2] fsverity: use shash API instead of ahash API
Previous by thread: Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic
Next by thread: Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]