On Fri, May 19, 2023 at 08:56:56PM -0700, Christoph Hellwig wrote: > On Fri, May 19, 2023 at 09:26:07PM -0400, Kent Overstreet wrote: > > On Fri, May 19, 2023 at 08:40:44AM +0100, David Howells wrote: > > > From: Christoph Hellwig <hch@xxxxxx> > > > > > > Replace BIO_NO_PAGE_REF with a BIO_PAGE_REFFED flag that has the inverted > > > meaning is only set when a page reference has been acquired that needs to > > > be released by bio_release_pages(). > > > > What was the motivation for this patch? > > So that is only is set when we need to release a page, instead telling > code to not release it when it otherwise would, where otherwise would > is implicit and undocumented and changes in this series. I suppose this way setting it can be done in bio_iov_iter_get_pages() - ok yeah, that makes sense. But it seems like it should be set in bio_iov_iter_get_pages() though, and I'm not seeing that?
