Re: [PATCH v6 2/3] mm: vmscan: move set_task_reclaim_state() near flush_reclaim_state()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yosry Ahmed <yosryahmed@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "Darrick J. Wong" <djwong@xxxxxxxxxx>, Christoph Lameter <cl@xxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Roman Gushchin <roman.gushchin@xxxxxxxxx>, Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>, "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>, Miaohe Lin <linmiaohe@xxxxxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, NeilBrown <neilb@xxxxxxx>, Shakeel Butt <shakeelb@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Yu Zhao <yuzhao@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v6 2/3] mm: vmscan: move set_task_reclaim_state() near flush_reclaim_state()
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Thu, 13 Apr 2023 13:19:02 +0200
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
In-reply-to: <20230413104034.1086717-3-yosryahmed@google.com>
Organization: Red Hat
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1

On 13.04.23 12:40, Yosry Ahmed wrote:

Move set_task_reclaim_state() near flush_reclaim_state() so that all
helpers manipulating reclaim_state are in close proximity.

Signed-off-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx>
---

Hm, it's rather a simple helper to set the reclaim_state for a task, notto modify it.


No strong opinion, but I'd just leave it as it.

--
Thanks,

David / dhildenb

Follow-Ups:
- Re: [PATCH v6 2/3] mm: vmscan: move set_task_reclaim_state() near flush_reclaim_state()
  - From: Yosry Ahmed

References:
- [PATCH v6 0/3] Ignore non-LRU-based reclaim in memcg reclaim
  - From: Yosry Ahmed
- [PATCH v6 2/3] mm: vmscan: move set_task_reclaim_state() near flush_reclaim_state()
  - From: Yosry Ahmed

Prev by Date: Re: [PATCH v6 1/3] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim
Next by Date: Re: [PATCH v6 3/3] mm: vmscan: refactor updating current->reclaim_state
Previous by thread: [PATCH v6 2/3] mm: vmscan: move set_task_reclaim_state() near flush_reclaim_state()
Next by thread: Re: [PATCH v6 2/3] mm: vmscan: move set_task_reclaim_state() near flush_reclaim_state()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]