On Thu, Mar 30, 2023 at 02:03:40AM +0200, Christoph Hellwig wrote: > > - v9fs_qid2ino(&st.qid), dt_type(&st)); > > + v9fs_qid2ino(&st.qid), v9fs_dt_type(&st)); > > This adds an overly long line. Also renaming the v9fs dt_type seems > like it should be a prep patch. > > > +/* Relationship between i_mode and the DT_xxx types */ > > This comment seems a bit terse. Agreed. Would be nice if we could just do proper kernel doc. Even for static inline functions it can't hurt.