On 3/29/23 1:52 PM, Linus Torvalds wrote: > On Wed, Mar 29, 2023 at 12:49 PM Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> We can get rid of these if we convert the iov_iter initializers to >> just assign the members rather than the copy+zero fill. The automatic >> zero fill is nice though, in terms of sanity. > > The automatic zero fill is good, but I think it should be fixed by > just not making that > > const struct iovec __ubuf_iovec; > > member be the first member of a union. > > The way union initializers work is that if they aren't named, they are > for the first member. > > So I *think* the reason you get that warning is literally just because > the __ubuf_iovec member is first in that union, and moving it down to > below the other struct will just fix things. Nope, still fails with it moved below. -- Jens Axboe
