On 3/29/23 1:30 PM, Linus Torvalds wrote:
> On Wed, Mar 29, 2023 at 11:41 AM Jens Axboe <axboe@xxxxxxxxx> wrote:
>>
>> + struct iovec __ubuf_iovec;
>
> I think this is the third time I say this: this should be "const struct iovec".
Doh sorry, not sure why I keep missing that... But yes, it should, I'll make
the edit and actually amend it.
> No other use is ever valid, and this cast:
>
>> +static inline const struct iovec *iter_iov(const struct iov_iter *iter)
>> +{
>> + if (iter->iter_type == ITER_UBUF)
>> + return (const struct iovec *) &iter->__ubuf_iovec;
>
> should simply not exist.
Yep. Fixed both up.
--
Jens Axboe
