On Tue, Mar 28, 2023 at 12:05 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> But it's not like adding a 'struct iovec' explicitly to the members
> just as extra "code documentation" would be wrong.
>
> I don't think it really helps, though, since you have to have that
> other explicit structure there anyway to get the member names right.
Actually, thinking a bit more about it, adding a
const struct iovec xyzzy;
member might be a good idea just to avoid a cast. Then that
iter_ubuf_to_iov() macro becomes just
#define iter_ubuf_to_iov(iter) (&(iter)->xyzzy)
and that looks much nicer (plus still acts kind of as a "code comment"
to clarify things).
Linus
