On Tue, Mar 28, 2023 at 11:55 AM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > I think it'll annoy gcc, and particularly the randstruct plugin. No, randstruct doesn't go change any normal data structure layout on its own. You have to actively mark things for randstruct, or they have to be pure function pointer ones. But it's not like adding a 'struct iovec' explicitly to the members just as extra "code documentation" would be wrong. I don't think it really helps, though, since you have to have that other explicit structure there anyway to get the member names right. So I don't hate your version, but I don't think it really helps either. Linus