Re: [PATCH v2] watch_queue: fix IOC_WATCH_QUEUE_SET_SIZE alloc error paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Christian Brauner (Microsoft) <brauner@xxxxxxxxxx>


On Tue, 07 Mar 2023 16:21:06 +0100, David Disseldorp wrote:
> The watch_queue_set_size() allocation error paths return the ret value
> set via the prior pipe_resize_ring() call, which will always be zero.
> 
> As a result, IOC_WATCH_QUEUE_SET_SIZE callers such as "keyctl watch"
> fail to detect kernel wqueue->notes allocation failures and proceed to
> KEYCTL_WATCH_KEY, with any notifications subsequently lost.
> 
> [...]

Unless someone got to it before me, I've now picked this up:

[1/1] watch_queue: fix IOC_WATCH_QUEUE_SET_SIZE alloc error paths
      commit: 03e1d60e177eedbd302b77af4ea5e21b5a7ade31

Thanks!
Christian



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux