On Sun, May 03, 2009 at 04:03:25AM -0400, Christoph Hellwig wrote:
> > +int vfs_reflink(struct dentry *old_dentry, struct inode *dir, struct dentry *new_dentry)
> >
> >+{
>
> Would be nice to have a little kerneldoc comment for it. Also please
> avoid the > 80 har lines
Both good points.
> > +EXPORT_SYMBOL(vfs_reflink);
>
> No really good reason to export this. Most vfs_ helpers are exported
> for nfsd, and I can't really see nfsd use this anytime soon.
While we're going forward with the system call, ocfs2's going to
support the ioctl for older kernels. I was planning to have mainline
just reroute the ioctl to vfs_reflink(), rather than have the ioctl
just break.
Joel
--
Life's Little Instruction Book #222
"Think twice before burdening a friend with a secret."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@xxxxxxxxxx
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
