> +int vfs_reflink(struct dentry *old_dentry, struct inode *dir, struct dentry *new_dentry) > >+{ Would be nice to have a little kerneldoc comment for it. Also please avoid the > 80 har lines > +EXPORT_SYMBOL(vfs_reflink); No really good reason to export this. Most vfs_ helpers are exported for nfsd, and I can't really see nfsd use this anytime soon. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html