On Sat, May 07, 2022 at 04:52:09PM +0800, Zorro Lang wrote: > On Sat, May 07, 2022 at 01:33:33AM +0000, xuyang2018.jy@xxxxxxxxxxx wrote: > > Hi Zorro > > > > Since Christian doesn't send a new patchset(for rename idmap-mount) > > based on lastest xfstests, should I send a v4 patch for the following > > patches today? > > "idmapped-mounts: Reset errno to zero after detect fs_allow_idmap" > > " idmapped-mounts: Add mknodat operation in setgid test" > > "idmapped-mounts: Add open with O_TMPFILE operation in setgid test" > > > > So you can merge these three patches if you plan to announce a new > > xfstests version in this weekend. > > > > What do you think about it? > > Sure, you can send V4 of patch 1/5 ～ 3/5 (base on latest for-next branch > please), as they have been reviewed and tested. Christian's patch (about > refactor idmapped testing) might need more review, he just sent it out to > get some review points I think (cc Christian). LSFMM happened last week so with travel and conference there simply was no time to rebase. It should be ready for merging once rebased. > > If you'd like to catch up the release of this weekend, please send your > v4 patch ASAP. Due to I need time to do regression test before pushing. > It'll wait for next week if too late. Rebasing the patchset is _massively_ painful which is why in the cover letter to it I requested that patches which is why I requested that currently pending patchsets that touch the same code please be applied on top of it. (I'm happy to apply them manually on top of my branch.) In any case, I'll have a rebased version ready on Monday (If there's no urgent issues I have to address somewhere else that I missed during travel.) Christian
