> > +void fat_truncate_atime(struct msdos_sb_info *sbi, struct timespec64 *ts, > > + struct timespec64 *atime) > > +void fat_truncate_crtime(struct msdos_sb_info *sbi, struct timespec64 *ts, > > + struct timespec64 *crtime) > > +void fat_truncate_mtime(struct msdos_sb_info *sbi, struct timespec64 *ts, > > + struct timespec64 *mtime) > > Small stuff and not strong opinion though, those are better to return > timespec64, instead of taking pointer? Because we can > > mtime = ctime = fat_truncate_mtime(sbi, &ts); It's ok. I can change them to this style. Thanks.