Re: [PATCH v4 1/3] fat: split fat_truncate_time() into separate functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +void fat_truncate_atime(struct msdos_sb_info *sbi, struct timespec64 *ts,
> > +                     struct timespec64 *atime)
> > +void fat_truncate_crtime(struct msdos_sb_info *sbi, struct timespec64 *ts,
> > +                      struct timespec64 *crtime)
> > +void fat_truncate_mtime(struct msdos_sb_info *sbi, struct timespec64 *ts,
> > +                     struct timespec64 *mtime)
>
> Small stuff and not strong opinion though, those are better to return
> timespec64, instead of taking pointer? Because we can
>
>         mtime = ctime = fat_truncate_mtime(sbi, &ts);

It's ok. I can change them to this style.

Thanks.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux