Re: [PATCH v4 1/3] fat: split fat_truncate_time() into separate functions

[OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>]

Chung-Chiang Cheng <cccheng@xxxxxxxxxxxx> writes:

> +/*
> + * truncate atime to 24 hour granularity (00:00:00 in local timezone)
> + */
> +void fat_truncate_atime(struct msdos_sb_info *sbi, struct timespec64 *ts,
> +			struct timespec64 *atime)

[...]

> +void fat_truncate_crtime(struct msdos_sb_info *sbi, struct timespec64 *ts,
> +			 struct timespec64 *crtime)

[...]

> +void fat_truncate_mtime(struct msdos_sb_info *sbi, struct timespec64 *ts,
> +			struct timespec64 *mtime)

Small stuff and not strong opinion though, those are better to return
timespec64, instead of taking pointer? Because we can

	mtime = ctime = fat_truncate_mtime(sbi, &ts);

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>