On Fri, Jan 21, 2022 at 03:55:14PM +0800, Muchun Song wrote: > Reuse some infrastructure of page_mkclean_one() to let DAX can handle > similar case to fix this issue. Can you split out some of the infrastructure changes into proper well-documented preparation patches? > + pgoff_t pgoff_end = pgoff_start + npfn - 1; > > i_mmap_lock_read(mapping); > - vma_interval_tree_foreach(vma, &mapping->i_mmap, index, index) { > - struct mmu_notifier_range range; > - unsigned long address; > - > + vma_interval_tree_foreach(vma, &mapping->i_mmap, pgoff_start, pgoff_end) { Please avoid the overly long lines here. Just using start and end might be an easy option.