On Thu, Dec 23, 2021 at 09:22:02AM +0100, Christoph Hellwig wrote: > On Wed, Dec 08, 2021 at 04:22:47AM +0000, Matthew Wilcox (Oracle) wrote: > > for (i = 0; i < pagevec_count(&pvec); i++) { > > - struct page *page = pvec.pages[i]; > > - size_t page_size = thp_size(page); > > - size_t offset = iocb->ki_pos & (page_size - 1); > > + struct folio *folio = page_folio(pvec.pages[i]); > > + size_t fsize = folio_size(folio); > > Any reason for fsize vs folio_size? CC mm/filemap.o ../mm/filemap.c: In function ‘filemap_read’: ../mm/filemap.c:2672:45: error: called object ‘folio_size’ is not a function or function pointer 2672 | size_t folio_size = folio_size(folio); | ^~~~~~~~~~ ../mm/filemap.c:2672:32: note: declared here 2672 | size_t folio_size = folio_size(folio); | ^~~~~~~~~~