On Wed, Dec 08, 2021 at 04:22:47AM +0000, Matthew Wilcox (Oracle) wrote: > for (i = 0; i < pagevec_count(&pvec); i++) { > - struct page *page = pvec.pages[i]; > - size_t page_size = thp_size(page); > - size_t offset = iocb->ki_pos & (page_size - 1); > + struct folio *folio = page_folio(pvec.pages[i]); > + size_t fsize = folio_size(folio); Any reason for fsize vs folio_size? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>