Roberto Bergantinos Corpas <rbergant@xxxxxxxxxx> wrote: > With addition of fs_context support, options string is parsed > sequentially, if 'sloppy' option is not leftmost one, we may > return ENOPARAM to userland if a non-valid option preceeds sloopy > and mount will fail : > > host# mount -o quota,sloppy 172.23.1.225:/share /mnt > mount.nfs: an incorrect mount option was specified > host# mount -o sloppy,quota 172.23.1.225:/share /mnt > host# > > This patch correct that behaviour so that sloppy takes precedence > if specified anywhere on the string It's slightly overcorrected, but that probably doesn't matter. I wonder if we should put a "bool sloppy" in struct fs_context, put the handling in vfs_parse_fs_param() (ie. skip the error message). David
