On Tue, Jul 20, 2021 at 08:59:45AM +0200, Christoph Hellwig wrote: > > + size_t poff = offset_in_folio(folio, *pos); > > + size_t plen = min_t(loff_t, folio_size(folio) - poff, length); > > These variables are a little misnamed now. But I'm not sure what a > better name would be. Yes, foff and flen would be ambiguous -- is f folio or file? I tend to prefer 'offset' and 'length', but we already have a loff_t length and having both a len and a length isn't conducive to understanding. Maybe rename loff_t length to extent_len? I'm going to leave it for now unless we have a really good suggestion. > > + size_t off = (page - &folio->page) * PAGE_SIZE + > > + bvec->bv_offset; > > Another use case for the helper I suggested earlier. Deleted in the very next patch, alas.
