On Wed, Apr 28, 2021 at 6:03 AM Christoph Hellwig <hch@xxxxxx> wrote: > > Unless Linus changed his mind just patching the file you care about for > now seems like the best idea. I'm ok with expanding splice() use, but I do want it to be on a case-by-case basis and with comments about what actually used splice() in the odd circumstances. Our splice infrastructure is probably a lot safer than it used to be now that set_fs() is gone, but splice() on odd files does remain historically a source of not just bugs, but bugs that were security issues. So it's mainly a "once bitten, twice shy" thing for me, which is why I'm more than happy to extend splice(), but want to do so in a very careful and controlled - and documented - manner, rather than the old situation where "pretty much everything can do splice, whether it actually works or not". Linus