On Fri, Apr 23, 2021 at 01:10:36PM +0200, Christian Brauner wrote: > There's a snafu here though stripping FMODE_* directly from flags would > cause the upper 32 bits to be truncated as well due to integer promotion > rules since FMODE_* is unsigned int, O_* are signed ints (yuck). > > This change shouldn't regress old open syscalls since they silently > truncate any unknown values. So, this is a change in behavior for openat. But given how new it is and there are not flags defined yet in the truncated range I think we should be fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx>