On Thu 28-01-21 15:12:27, bingjingc wrote: > From: BingJing Chang <bingjingc@xxxxxxxxxxxx> > > The uid/gid (unsigned int) of a domain user may be larger than INT_MAX. > The parse_options of isofs and udf will return 0, and mount will fail > with -EINVAL. These patches try to handle large user and group ID. > > BingJing Chang (3): > parser: add unsigned int parser > isofs: handle large user and group ID > udf: handle large user and group ID Thanks for your patches! Just two notes: 1) I don't think Matthew Wilcox gave you his Reviewed-by tag (at least I didn't see such email). Generally the rule is that the developer has to explicitely write in his email that you can attach his Reviewed-by tag for it to be valid. 2) Please split the cleanup of kernel doc comments in lib/parser.c in a separate patch. It is unrelated to adding parse_uint() function so it belongs into a separate patch (we occasionally do include small unrelated cleanups if they are on the same line we change anyway but your changes definitely triggered my treshold of this should be a separate patch). Thanks! Honza > > fs/isofs/inode.c | 9 +++++---- > fs/udf/super.c | 9 +++++---- > include/linux/parser.h | 1 + > lib/parser.c | 44 +++++++++++++++++++++++++++++++++----------- > 4 files changed, 44 insertions(+), 19 deletions(-) > > -- > 2.7.4 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
