On 1/3/21 10:31 PM, Al Viro wrote: > On Mon, Dec 14, 2020 at 12:13:20PM -0700, Jens Axboe wrote: >> Hi, >> >> Wanted to throw out what the current state of this is, as we keep >> getting closer to something palatable. >> >> This time I've included the io_uring change too. I've tested this through >> both openat2, and through io_uring as well. >> >> I'm pretty happy with this at this point. The core change is very simple, >> and the users end up being trivial too. >> >> Also available here: >> >> https://git.kernel.dk/cgit/linux-block/log/?h=nonblock-path-lookup > > OK, pushed with modifications into vfs.git #work.namei > > Changes: dropped a couple of pointless pieces in open_last_lookups()/do_open(), > moved O_TMPFILE rejection into build_open_flags() (i.e. in the third of your > commits). And no io_uring stuff in there - your #4 is absent. > > I've not put it into #for-next yet; yell if you see any problems with that > branch, or it'll end up there ;-) Thanks Al - but you picked out of v3, not v4. Not that there are huge changes between the two, from the posting of v4: - Rename LOOKUP_NONBLOCK -> LOOKUP_CACHED, and ditto for the RESOLVE_ flag. This better explains what the feature does, making it more self explanatory in terms of both code readability and for the user visible part. - Remove dead LOOKUP_NONBLOCK check after we've dropped LOOKUP_RCU already, spotted by Al. - Add O_TMPFILE to the checks upfront, so we can drop the checking in do_tmpfile(). and it sounds like you did the last two when merging yourself. I do like LOOKUP_CACHED better than LOOKUP_NONBLOCK, mostly for the externally self-documenting feature of it. What do you think? Here's the v4 posting, fwiw: https://lore.kernel.org/linux-fsdevel/20201217161911.743222-1-axboe@xxxxxxxxx/ -- Jens Axboe
