On Wed, 5 November 2008 23:44:23 -0800, Warren Turkal wrote: > > -hfsplus-objs := super.o options.o inode.o ioctl.o extents.o catalog.o dir.o btree.o \ > - bnode.o brec.o bfind.o tables.o unicode.o wrapper.o bitmap.o part_tbl.o > +hfsplus-objs := super.o options.o inode.o ioctl.o extents.o catalog.o dir.o \ > + btree.o bnode.o brec.o bfind.o tables.o unicode.o wrapper.o \ > + bitmap.o part_tbl.o journal.o Didn't check-read your patch? Remove, please. > diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h > index f027a90..9018d2d 100644 > --- a/fs/hfsplus/hfsplus_fs.h > +++ b/fs/hfsplus/hfsplus_fs.h > @@ -421,4 +421,6 @@ static inline struct hfsplus_inode_info *HFSPLUS_I(struct inode *inode) > > #define kdev_t_to_nr(x) (x) > > +bool hfsp_vol_has_journal(struct hfsplus_vh *vhdr); > + The function is only ever used in super.c. Just leave it in the same file and make it static. Jörn -- Premature optimization is the root of all evil. -- Donald Knuth -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html