On Wed, Nov 05, 2008 at 11:40:54AM +0100, J??rn Engel wrote:
> On Wed, 5 November 2008 00:00:26 -0800, Warren Turkal wrote:
> >
> > + vhdr->journal_info_block != cpu_to_be32(0)) {
>
> 0 doesn't need explicit cpu_to_be32(). You can drop the whole
> != cpu_to_be32(0)
>
> > + (be32_to_cpu(vhdr->journal_info_block) != 0) &&
>
> Same here.
Yeah. In addition adding a little helper that checks both the journal
flag and the non-zeroness of journal_info_block would be useful so that
everyone adding more checks like this in the future get it right.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
