Johhanes/Christoph, On 12/10/20 23:30, Johannes Thumshirn wrote: > On 09/12/2020 14:41, Johannes Thumshirn wrote: >> On 09/12/2020 11:18, Johannes Thumshirn wrote: >>> On 09/12/2020 11:10, hch@xxxxxxxxxxxxx wrote: >>>> On Wed, Dec 09, 2020 at 10:08:53AM +0000, Johannes Thumshirn wrote: >>>>> On 09/12/2020 10:34, Christoph Hellwig wrote: >>>>>> Btw, another thing I noticed: >>>>>> >>>>>> when using io_uring to submit a write to btrfs that ends up using Zone >>>>>> Append we'll hit the >>>>>> >>>>>> if (WARN_ON_ONCE(is_bvec)) >>>>>> return -EINVAL; >>>>>> >>>>>> case in bio_iov_iter_get_pages with the changes in this series. >>>>> Yes this warning is totally bogus. It was in there from the beginning of the >>>>> zone-append series and I have no idea why I didn't kill it. >>>>> >>>>> IIRC Chaitanya had a patch in his nvmet zoned series removing it. Even though that patch is not needed I've tested that with the NVMeOF backend to build bios from bvecs with bio_iov_iter_get_pages(), I can still send that patch, please confirm.
