On Wed, Dec 09, 2020 at 10:08:53AM +0000, Johannes Thumshirn wrote: > On 09/12/2020 10:34, Christoph Hellwig wrote: > > Btw, another thing I noticed: > > > > when using io_uring to submit a write to btrfs that ends up using Zone > > Append we'll hit the > > > > if (WARN_ON_ONCE(is_bvec)) > > return -EINVAL; > > > > case in bio_iov_iter_get_pages with the changes in this series. > > Yes this warning is totally bogus. It was in there from the beginning of the > zone-append series and I have no idea why I didn't kill it. > > IIRC Chaitanya had a patch in his nvmet zoned series removing it. Yes, but it is wrong. What we need is a version of __bio_iov_bvec_add_pages that takes the hardware limits into account.
