On Wed, Oct 28, 2020 at 11:05 PM Tony Asleson <tasleson@xxxxxxxxxx> wrote: > On 10/28/20 3:45 PM, Tony Asleson wrote: > > On 10/26/20 5:07 PM, Andy Shevchenko wrote: > > >>> + dev_err_ratelimited(gendev, > >>> + "Buffer I/O error, logical block %llu%s\n", > >> > >>> + (unsigned long long)bh->b_blocknr, msg); > >> > >> It's a u64 always (via sector_t), do we really need a casting? > > > > That's a good question, grepping around shows *many* instances of this > > being done. I do agree that this doesn't seem to be needed, but maybe > > there is a reason why it's done? > > According to this: > > https://www.kernel.org/doc/html/v5.9/core-api/printk-formats.html > > This should be left as it is, because 'sector_t' is dependent on a > config option. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/linux/types.h?id=72deb455b5ec619ff043c30bc90025aa3de3cdda Staled documentation. You may send a patch to fix it (I Cc'ed Christoph and Jonathan). It means that it doesn't go under this category and the example should be changed to something else. -- With Best Regards, Andy Shevchenko
