On 10/28/20 3:45 PM, Tony Asleson wrote: > On 10/26/20 5:07 PM, Andy Shevchenko wrote: >>> + dev_err_ratelimited(gendev, >>> + "Buffer I/O error, logical block %llu%s\n", >> >>> + (unsigned long long)bh->b_blocknr, msg); >> >> It's a u64 always (via sector_t), do we really need a casting? > > That's a good question, grepping around shows *many* instances of this > being done. I do agree that this doesn't seem to be needed, but maybe > there is a reason why it's done? According to this: https://www.kernel.org/doc/html/v5.9/core-api/printk-formats.html This should be left as it is, because 'sector_t' is dependent on a config option. -Tony
