On Fri, 2008-10-10 at 09:37 -0400, Theodore Tso wrote: > On Fri, Oct 10, 2008 at 09:13:25AM -0400, Christoph Hellwig wrote: > > On Fri, Oct 10, 2008 at 09:10:30AM -0400, Theodore Tso wrote: > > > > Aneesh has a patch to kill the range_cont flag, which is queued up for > > > > 2.6.28. > > > > > > Which tree is this queued up in? It's not in ext4 or the mm tree... > > > > Oh, it' not queued up yet? It's part of the patch that switches ext4 > > to it's own copy of write_cache_pages to fix the buffer write issues. > > > > I held off queing it up since the version Aneesh did created ext4's > own copy of write_cache_pages, and given that Nick has a bunch of > fixes and improvements for write_cache_pages, it confirmed my fears > that queueing a patch which copied ~100 lines of code into ext4 was > probably not the best way to go. > What I was hoping for when I suggested copying it in was a larger move of logic from the ext4 writepages code into the ext4 write_cache_pages. The idea was to see what ext4 really needed write_cache_pages to do, but Aneesh knows much better than I do there. But, given that the change was only a few lines, I think it makes sense to fold it back into write_cache_pages. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
