On Thu, Oct 09, 2008 at 04:23:36AM -0400, Christoph Hellwig wrote: > On Fri, Oct 10, 2008 at 02:50:43AM +1100, npiggin@xxxxxxx wrote: > > In the range_cont case, range_start is set to index << PAGE_CACHE_SHIFT, but > > index is a pgoff_t and range_start is loff_t, so we can get truncation of the > > value on 32-bit platforms. Fix this by adding the standard loff_t cast. > > > > This is a data interity bug (depending on how range_cont is used). > > Aneesh has a patch to kill the range_cont flag, which is queued up for > 2.6.28. OK, great. I guess actually this patch out of all of them could go into 2.6.27 and previous stable kernels because it is obviously correct and could not really cause a regression. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
