Christoph Hellwig wrote: > * FIEMAP_EXTENT_ENCODED I like this name better, it seems clearer what it means. > This extent does not consistant of plain filesystem blocks but is > encoded (e.g. encrypted or compressed) or shared with other data by the ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > filesystem. ^^^^^^^^^^ Shared blocks must not be overwritten to the block device when unmounted - but they might be safe to *read*, e.g. by LILO. Shared data is not the only situation where it's unsafe to overwrite blocks in place but they can be read: anything wich data-dependent metadata, such as checksums, data version numbers or indexing. Thus: FIEMAP_EXTENT_READ_ENCODED FIEMAP_EXTENT_WRITE_ENCODED where #define FIEMAP_EXTENT_ENCODED \ (FIEMAP_EXTENT_READ_ENCODED | FIEMAP_EXTENT_WRITE_ENCODED) > Except for continuous nitpicking about this flag which could be > continued in mainline before a release this patch looks good to me. I agree, if there are remaining nits they can be continued in mainline. -- Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html