On Sat, Aug 29, 2020 at 11:24:06AM +0200, Christoph Hellwig wrote: > On Thu, Aug 27, 2020 at 11:06:28AM -0700, Linus Torvalds wrote: > > On Thu, Aug 27, 2020 at 8:00 AM Christoph Hellwig <hch@xxxxxx> wrote: > > > > > > Once we can't manipulate the address limit, we also can't test what > > > happens when the manipulation is abused. > > > > Just remove these tests entirely. > > > > Once set_fs() doesn't exist on x86, the tests no longer make any sense > > what-so-ever, because test coverage will be basically zero. > > > > So don't make the code uglier just to maintain a fiction that > > something is tested when it isn't really. > > Sure fine with me unless Kees screams. If we don't have set_fs, we don't need the tests. :) -- Kees Cook
