Re: [PATCH 17/17] file: Rename __close_fd to close_fd and remove the files parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 17/17] file: Rename __close_fd to close_fd and remove the files parameter
From: ebiederm@xxxxxxxxxxxx (Eric W. Biederman)
Date: Tue, 18 Aug 2020 07:48:21 -0500
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, criu@xxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <christian.brauner@xxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Cyrill Gorcunov <gorcunov@xxxxxxxxx>, Jann Horn <jann@xxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, "Daniel P. Berrang\?\?" <berrange@xxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Matthew Wilcox <matthew@xxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Martin KaFai Lau <kafai@xxxxxx>, Song Liu <songliubraving@xxxxxx>, Yonghong Song <yhs@xxxxxx>, Andrii Nakryiko <andriin@xxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxxxx>
In-reply-to: <20200818112020.GA17080@infradead.org> (Christoph Hellwig's message of "Tue, 18 Aug 2020 12:20:20 +0100")
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

> Please kill off ksys_close as well while you're at it.

Good point.  ksys_close is just a trivial wrapper around close_fd.  So
the one caller of ksys_close autofs_dev_ioctl_closemount can be
trivially changed to call close_fd.

Eric

References:
- exec: Move unshare_files and guarantee files_struct.count is correct
  - From: Eric W. Biederman
- [PATCH 17/17] file: Rename __close_fd to close_fd and remove the files parameter
  - From: Eric W. Biederman
- Re: [PATCH 17/17] file: Rename __close_fd to close_fd and remove the files parameter
  - From: Christoph Hellwig

Prev by Date: Re: file metadata via fs API
Next by Date: Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control
Previous by thread: Re: [PATCH 17/17] file: Rename __close_fd to close_fd and remove the files parameter
Next by thread: [PATCH v4 0/3] Try to release mmap_lock temporarily in smaps_rollup
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]