On Sun, May 10, 2020 at 11:54:56AM +0530, Ritesh Harjani wrote: > This adds process name and pid for ext4_msg(). > I found this to be useful. For e.g. below print gives more > info about process name and pid. > > [ 7671.131912] [mount/12543] EXT4-fs (dm-0): mounted filesystem with ordered data mode. Opts: acl,user_xattr I'm not entirely sure about adding the command/pid at the beginning of the message. The way we do this in ext4_warning and ext4_err is to print that information like this: printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: comm %s: %pV\n", sb->s_id, function, line, current->comm, &vaf); ... and I wonder if it would make more sense to add something like to ext4_msg(), just out of consistency's sake. Which of the debugging messages were you finding this to be most helpful? - Ted
