Re: [PATCH 00/12] vfs patch queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 13, 2020 at 09:47:07AM +0200, Miklos Szeredi wrote:
> On Tue, May 5, 2020 at 11:59 AM Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote:
> >
> > Hi Al,
> >
> > Can you please apply the following patches?
> 
> Ping?  Could you please have a look at these patches?
> 
> - /proc/mounts cursor is almost half the total lines changed, and that
> one was already pretty damn well reviewed by you
> 
> - unprivileged whiteout one was approved by the security guys
> 
> - aio fsync one is a real bug, please comment on whether the patch is
> acceptable or should I work around it in fuse
> 
> - STATX_MNT_ID extension is a no brainer, the other one may or may not
> be useful, that's arguable...
> 
> - the others are not important, but I think useful
> 
> - and I missed one (faccess2); amending to patch series

I can live with that, modulo couple of trivial nits.  Have you tested the
/proc/mounts part for what happens if it's opened shitloads of times,
with each instance lseek'ed a bit forward (all to the same position, that
is)?  That, in principle, allows an unpriveleged user to pile a lot of list
entries and cause serious looping under a spinlock...



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux