On Wed 13-05-20 14:10:54, Amir Goldstein wrote: > On Wed, May 13, 2020 at 2:08 PM Jan Kara <jack@xxxxxxx> wrote: > > > > On Tue 12-05-20 21:32:10, Amir Goldstein wrote: > > > On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@xxxxxxxxx> wrote: > > > > > > > > This small patchset does some cleanup in fs/notify branch > > > > especially in fanotify. > > > > > > Patches look fine to me. > > > I would just change the subject of patches from notify: to fsnotify:. > > > The patch "explicit shutdown initialization" is border line unneeded > > > and its subject is not very descriptive. > > > Let's wait and see what Jan has to say before you post another round. > > > > Yeah, I think patch 2 doesn't make sence but the rest looks good. Can I add > > your Reviewed-by Amir when merging them? > > Yes. Thanks. Fabian, I've merged the cleanups to my tree. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR