Re: [PATCH V2 0/6 linux-next] fs/notify: cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@xxxxxxxxx> wrote:
>
> This small patchset does some cleanup in fs/notify branch
> especially in fanotify.

Patches look fine to me.
I would just change the subject of patches from notify: to fsnotify:.
The patch "explicit shutdown initialization" is border line unneeded
and its subject is not very descriptive.
Let's wait and see what Jan has to say before you post another round.

Thanks,
Amir.

>
> V2:
> Apply Amir Goldstein suggestions:
> -Remove patch 2, 7 and 9
> -Patch "fanotify: don't write with zero size" ->
> "fanotify: don't write with size under sizeof(response)"
>
> Fabian Frederick (6):
>   fanotify: prefix should_merge()
>   notify: explicit shutdown initialization
>   notify: add mutex destroy
>   fanotify: remove reference to fill_event_metadata()
>   fsnotify/fdinfo: remove proc_fs.h inclusion
>   fanotify: don't write with size under sizeof(response)
>
>  fs/notify/fanotify/fanotify.c      | 4 ++--
>  fs/notify/fanotify/fanotify_user.c | 8 +++++---
>  fs/notify/fdinfo.c                 | 1 -
>  fs/notify/group.c                  | 2 ++
>  4 files changed, 9 insertions(+), 6 deletions(-)
>
> --
> 2.26.2
>



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux