On Mon, Apr 27, 2020 at 7:32 AM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote: > > Would hlists_swap_heads_rcu be noticably better? Edited out most of the rest because I think we're in agreement and it's not a huge deal. And yes, I think it might be nice to just call it "swap_heads()" and make the naming match what the user wants, so that people who don't care about the implementation can just guess from the function name. But I also think that by now it's mostly bikeshedding, and I'm probably also now biased by the fact that I have looked at that code and read your explanations so it's all fresh in my mind. A year from now, when I've forgotten the details, who knows which part I'd find confusing? ;) Linus