On Tue, Mar 03, 2020 at 02:34:42PM +0100, Miklos Szeredi wrote: > On Tue, Mar 3, 2020 at 2:14 PM Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > Unlimited beers for a 21-line kernel patch? Sign me up! > > > > > > Totally untested, barely compiled patch below. > > > > Ok, that didn't even build, let me try this for real now... > > Some comments on the interface: > > O_LARGEFILE can be unconditional, since offsets are not exposed to the caller. > > Use the openat2 style arguments; limit the accepted flags to sane ones > (e.g. don't let this syscall create a file). If we think this is worth it, might even good to either have it support struct open_how or have it accept two flag arguments. We sure want openat2()s RESOLVE_* flags in there. Christian