On Wed, Feb 26, 2020 at 10:20 AM Jan Kara <jack@xxxxxxx> wrote: > > On Mon 17-02-20 15:14:46, Amir Goldstein wrote: > > The event inode field is used only for comparison in queue merges and > > cannot be dereferenced after handle_event(), because it does not hold a > > refcount on the inode. > > > > Replace it with an abstract tag do to the same thing. We are going to > > set this tag for values other than inode pointer in fanotify. > > > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > I like this but can we call it say 'objectid' or something like that? 'tag' > seems too generic to me and it isn't clear why we should merge or not merge > events with different tags... Sounds good to me. And I agree to the comment about fsnotify_init_event() Apropos event merging, I ran across a simple create/delete files workload where fanotify_merge() was hogging the CPU. I currently carry a small private patch to limit the merge depth to 128 recent events. I still didn't have time to think about the best way to deal with this properly. Thanks, Amir.
