On Mon 17-02-20 15:14:46, Amir Goldstein wrote:
> The event inode field is used only for comparison in queue merges and
> cannot be dereferenced after handle_event(), because it does not hold a
> refcount on the inode.
>
> Replace it with an abstract tag do to the same thing. We are going to
> set this tag for values other than inode pointer in fanotify.
...
> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
> -static inline void fsnotify_init_event(struct fsnotify_event *event,
> - struct inode *inode)
> +static inline void fsnotify_init_event(struct fsnotify_event *event, void *tag)
> {
> INIT_LIST_HEAD(&event->list);
> - event->inode = inode;
> + event->tag = (unsigned long)tag;
> }
Oh, and why not make the argument to fsnotify_init_event() unsigned long
from the start? It would be IMHO cleaner and using void * doesn't really
save us many type casts...
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
