On 2/7/20 5:18 AM, Stefano Garzarella wrote: > In io_uring_poll() we must flush overflowed CQ events before to > check if there are CQ events available, to avoid missing events. > > We call the io_cqring_events() that checks and flushes any overflow > and returns the number of CQ events available. > > We can avoid taking the 'uring_lock' since the flush is already > protected by 'completion_lock'. Thanks, applied. I dropped that last sentence, as a) it doesn't really matter, and b) we may very well already have it held here if someone is doing a poll on the io_uring fd itself. -- Jens Axboe